Repository navigation
Preview: error codes are always strings - #794
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
geetikabagga
approved these changes
Nov 5, 2026
Contributor
There was a problem hiding this comment.
Approve. Preview now matches what the API sends.
- Monolith:
error_handler.rb:316rendersApiErrorstatus asto_swhenRenderValidationErrorCodeAsStringis active. That's registered in theUnstableVersionblock (service.rb:541) and pinned by the intercom/intercom#604442 companies spec (HTTP 400,"422"on Unstable,422on released versions). No integercode:is left indescriptions/0/. - Scope: only
descriptions/0/changes, and 2.17 keeps theanyOf. The 2.18 tracker (intercom/intercom#593318) has this class as Ready with only the OpenAPI and dev-docs gaps, so api-cut-docs should graduate this diff into 2.18. It needs to merge before the 2026-11-06 gap deadline. - intercom/developer-docs#1338: the changed lines are identical to this diff, and the
@Previewchangelog entry matches. fern check(5.65.3): 0 errors, 317 warnings, the same as base.
Non-blocking: could you link intercom/intercom#604442 in the body or squash commit, as intercom/developer-docs#1338 does? Then the cut's git log -S trace lands on a commit that names the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
On the Preview version,
errors[].codeis now always a string, but the spec still showed the "Company is not an object" example onPOST /companieswith the number422and allowed a numeric code in the error schema.How?
Changes that example to
"422"and makes the Preview errorcodea string again; the numbered versions still return the number and are unchanged.Generated with Claude Code